I had the same issue with knocking noise in the upstairs bathroom behind the shower cabin.
Plumber came, opened the wall, installed additional arrestor... still the same...
Then he installed a big arrester in the basement on water intake pipe .... still the same knocking noise...
At the end, he...